Do library rescan on compile (if no profies are used) #1758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmaglie
added
priority: high
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)What kind of change does this PR introduce?
The compiler will now detect changes in the filesystem when not using profiles. This fixes a regression described in #1755
What is the current behavior?
The daemon caches all the libraries installed in the sketchbook. This provides a quicker compile but it prevents detection of changes in the sketchbook happening outside the daemon process.
What is the new behavior?
Libraries are re-scanned at each compile.
Does this PR introduce a breaking change, and is titled accordingly?
No
Other Information:
Fix #1755
Integration-testing requires the implementation of a testing harness to test gRPC and launch the daemon, this will be done in the future.