[skip changelog] Update cobra to latest version #1430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
silvanocerza
approved these changes
Sep 3, 2021
silvanocerza
changed the title
per1234
added
topic: infrastructure
silvanocerza
pushed a commit
that referenced
this pull request
Sep 30, 2021
* bump github.com/spf13/cobra to 1.2.1 * go mod tidy * fix CI failing * update powershell tests, in new version of cobra the completion file is different
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)Dependency update
This PR is required to add the newly added dynamic completion 😏
I also updated the tests since the completion for powershell is changed a little bit
titled accordingly?
no
See how to contribute