Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make avr and sam files more similar to aid #5771 #5775

Closed
wants to merge 1 commit into from
Closed

Make avr and sam files more similar to aid #5771 #5775

wants to merge 1 commit into from

Conversation

eric-wieser
Copy link
Contributor

@eric-wieser eric-wieser commented Dec 29, 2016 •
edited
Loading

Pulls the per-platform code in Print.cpp into its own file, so that both Print.cpps are now identical.

Also corrects style divergence between otherwise-identical files. Hopefully this helps with #5771

@cousteaulecommandant cousteaulecommandant mentioned this pull request Jan 19, 2017
Closed
@facchinm facchinm added the Print and Stream class The Arduino core library's Print and Stream classes label Jan 20, 2017
@cmaglie
Copy link
Member

cmaglie commented Jan 24, 2017

the SAM core actually has a avr/pgmspace.h placeholder, I think we can just copy the Print.cpp over as-is from AVR (on the SAMD core we already do that).

@sandeepmistry
Copy link
Contributor

Closing as the two files should be the same now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Print and Stream class The Arduino core library's Print and Stream classes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eric-wieser @cmaglie @sandeepmistry @facchinm