Include library paths used by libraries in the compiler search path (take 2) #1726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code looks good. I added some inline comments in the last commit. I have some other thoughts on the code structure, but those depend a bit on how the 1.5 library layout will turn out (I have some thoughts about this as well, I'm hoping to write a proposal for an improved layout somewhere this week). I'll perhaps pull your code later today to do some testing as well. |
|
One more thing: These patches don't fix #636 yet, right? I don't hink .cpp and .h files inside a sketch are now inspected by the preprocessor? |
matthijskooijman
added a commit
to Pinoccio/library-pinoccio
that referenced
this pull request
Jan 22, 2014
Since the Arduino IDE doesn't do recursive library dependencies yet (arduino/Arduino#1726), we'll have to include all of these explicitely.
|
For the record, this pullrequest fixes #236. |
Merge branch 'ide-1.5.x' into lib-import
|
Outdated with #2174 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally started by @giseburt on #1250
This pull fixes a case where libraries that a sketch uses indirectly (other libraries is uses require them) need to be included directly in order to compile.
It is necessary to #include a library's file in your sketch in order for the IDE to add that library's path to the compiler command line. This patch searches the files that are included as well, adding dependent libraries to the search path. This removes then need to directly #include indirectly used libraries.
It takes into account also Matthijs suggestion:
Moreover:
BTW, I'm still not fully convinced about this patch, more tests welcome.
C