Add function getYears, getMonths, getDays #184
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
per1234
added
type: enhancement
|
Hello @per1234 , |
|
Hi @thaianhtaivn. Thanks for your pull request. My role in this project is somewhat janitorial in nature. I don't make the decisions about which pull requests are merged or not. I commented to provide some supplemental information that might be of use to the reviewers. Regards, |
lukaszgieraltowski
suggested changes
Jan 27, 2023
| @@ -148,6 +148,27 @@ int NTPClient::getMinutes() const { | |||
| int NTPClient::getSeconds() const { | |||
| return (this->getEpochTime() % 60); | |||
| } | |||
| int NTPClient::getYears() const { | |||
| time_t rawtime = this->getEpochTime(); | |||
There was a problem hiding this comment.
Use two spaces for indentation instead of four.
| @@ -85,6 +85,9 @@ class NTPClient { | |||
| int getHours() const; | |||
| int getMinutes() const; | |||
| int getSeconds() const; | |||
| int getYears() const; | |||
There was a problem hiding this comment.
Use two spaces for indentation instead of tab.
|
@thaianhtaivn Actually this was already implemented #94 but not merged :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Already tested function with platformIO & ESP8266.