-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility with new ESP32 cores #112
base: master
Are you sure you want to change the base?
Conversation
Memory usage change @ 14cec23
Click for full report table
Click for full report CSV
|
Hi @per1234 This is bad solution? Need to change something? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your pull request @Laxilef!
I thought I should add a note that a proposal has now been submitted to revert the breaking change in the esp32 platform's Client
API: espressif/arduino-esp32#10776
If accepted, that change would render this pull request superfluous, with the exception of providing compatibility with esp32 platform version 3.1.0 specifically.
Hi,
Starting from version 3.1.x, the
Client
must implement the following methods: