Skip to content

Commit

Permalink
media: tm6000: use irqsave() in USB's complete callback
Browse files Browse the repository at this point in the history
The USB completion callback does not disable interrupts while acquiring
the lock. We want to remove the local_irq_disable() invocation from
__usb_hcd_giveback_urb() and therefore it is required for the callback
handler to disable the interrupts while acquiring the lock.
The callback may be invoked either in IRQ or BH context depending on the
USB host controller.
Use the _irqsave() variant of the locking primitives.

Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Acked-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Sebastian Andrzej Siewior authored and gregkh committed Sep 10, 2018
1 parent 273925c commit 3f3ff6e
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions drivers/media/usb/tm6000/tm6000-video.c
Original file line number Diff line number Diff line change
Expand Up @@ -419,6 +419,7 @@ static void tm6000_irq_callback(struct urb *urb)
{
struct tm6000_dmaqueue *dma_q = urb->context;
struct tm6000_core *dev = container_of(dma_q, struct tm6000_core, vidq);
unsigned long flags;
int i;

switch (urb->status) {
Expand All @@ -436,9 +437,9 @@ static void tm6000_irq_callback(struct urb *urb)
break;
}

spin_lock(&dev->slock);
spin_lock_irqsave(&dev->slock, flags);
tm6000_isoc_copy(urb);
spin_unlock(&dev->slock);
spin_unlock_irqrestore(&dev->slock, flags);

/* Reset urb buffers */
for (i = 0; i < urb->number_of_packets; i++) {
Expand Down

0 comments on commit 3f3ff6e

Please sign in to comment.