-
-
Notifications
You must be signed in to change notification settings - Fork 810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTTP executor should error when both data and errors fields are empty #5902
Conversation
🦋 Changeset detectedLatest commit: 4d87479 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Benchmark Results
|
💻 Website PreviewThe latest changes are available as preview in: https://988885fa.graphql-tools.pages.dev |
e840318
to
4d87479
Compare
return JSON.parse(result); | ||
const parsedResult = JSON.parse(result); | ||
if ( | ||
parsedResult.data == null && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These need to check for undefined as well. E.g. the response is {notGraphql: true}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
== null
(not ===
) should check for both undefined and null.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 woops
I'm too used to strict typescript rules. No ==
for me :)
No description provided.