Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(federation/buildSubgraphSchema): do not create an invalid _Entity union if there is no entity defined #5885

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

ardatan
Copy link
Owner

@ardatan ardatan commented Feb 8, 2024

Closes #5884

Copy link

changeset-bot bot commented Feb 8, 2024

🦋 Changeset detected

Latest commit: c1dfbe2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@graphql-tools/federation Patch
federation-benchmark Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Feb 8, 2024

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-tools/federation 1.1.15-alpha-20240208110858-c1dfbe2a7a411dbf6307a33ce330f7cfa0ace7d2 npm ↗︎ unpkg ↗︎

Copy link
Contributor

github-actions bot commented Feb 8, 2024

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.........................: 100.00% ✓ 336       ✗ 0  
     data_received..................: 39 MB   3.9 MB/s
     data_sent......................: 144 kB  14 kB/s
     http_req_blocked...............: avg=3.99µs   min=1.96µs   med=2.64µs  max=186.13µs p(90)=3.73µs   p(95)=4.24µs  
     http_req_connecting............: avg=782ns    min=0s       med=0s      max=131.39µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=55.56ms  min=45.86ms  med=53.05ms max=143.1ms  p(90)=61.07ms  p(95)=87.02ms 
       { expected_response:true }...: avg=55.56ms  min=45.86ms  med=53.05ms max=143.1ms  p(90)=61.07ms  p(95)=87.02ms 
     http_req_failed................: 0.00%   ✓ 0         ✗ 168
     http_req_receiving.............: avg=135.73µs min=106.06µs med=127µs   max=471.78µs p(90)=150.51µs p(95)=179.66µs
     http_req_sending...............: avg=36.12µs  min=16.19µs  med=23.31µs max=1.94ms   p(90)=29.32µs  p(95)=33.91µs 
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s      max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=55.39ms  min=45.71ms  med=52.9ms  max=142.76ms p(90)=60.91ms  p(95)=86.6ms  
     http_reqs......................: 168     16.726654/s
     iteration_duration.............: avg=59.76ms  min=49.34ms  med=56.84ms max=149.95ms p(90)=65.22ms  p(95)=90.8ms  
     iterations.....................: 168     16.726654/s
     vus............................: 1       min=1       max=1
     vus_max........................: 1       min=1       max=1

Copy link
Contributor

github-actions bot commented Feb 8, 2024

💻 Website Preview

The latest changes are available as preview in: https://be731e84.graphql-tools.pages.dev

@ardatan ardatan merged commit 2d76909 into master Feb 8, 2024
29 checks passed
@ardatan ardatan deleted the federation-no-entity branch February 8, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant