added native support for using apollo-link as the network layer #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freiksenet
reviewed
Oct 4, 2017
| const result = await fetcher({ | ||
| query, | ||
| const result = await makePromise(execute(link, { | ||
| query: typeof query === 'string' ? parse(query) : query, |
There was a problem hiding this comment.
What does link accept exactly? Cause we have parsed document already above and we print it. If it accepts parsed document, then we should pass it the parsed document.
src/stitching/introspectSchema.ts
Outdated
| link = fetcherToLink(link as Fetcher); | ||
| } | ||
| const introspectionResult = await makePromise(execute((link as ApolloLink), { | ||
| query: typeof introspectionQuery === 'string' ? parse(introspectionQuery) : introspectionQuery, |
There was a problem hiding this comment.
We should cache parsed introspection query.
|
Is depending on apollo-link a good idea? It gets our bundle size from 9KB to 15KB, that's 1.5x size increase and it is only used in one small part of the library. Is it warranted? Can we somehow get around it? I know it's a server-side package, but people did complain about bundle size already, so we need to always consider if it's worth adding more dependencies. |
|
Maybe I'm overthinking it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts the fetcher portion of graphql-tools to accept a link or a fetcher. The idea is we would deprecate (potentially) using a fetcher in favor of a link stack since it makes it easier to do more complex actions and long term would make things like stitched
defer,live, and more possible.Docs link: https://github.com/apollographql/tools-docs/pull/135