-
-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Types for SchemaDirectiveVisitor.visitSchemaDirectives
broken in 5.0.0 branch
#1376
Comments
Thanks so much for the wonderful reproduction! |
yaacovCR
added a commit
that referenced
this issue
Apr 21, 2020
= Use Record instead of { [key: string]: <whatever> } when possible. = Use any for SchemaDirectiveVisitor generic default, a simpler attempt at #1376 = Add typescript check, as rollup seems to fail only on semantic/syntax errors, not type errors
yaacovCR
added a commit
that referenced
this issue
Apr 21, 2020
= Use Record instead of { [key: string]: <whatever> } when possible. = Use any for SchemaDirectiveVisitor generic default, a simpler attempt at #1376 = Add typescript check, as rollup seems to fail only on semantic/syntax errors, not type errors
That was impressively fast @yaacovCR - I really appreciate you helping out! |
yaacovCR
added a commit
that referenced
this issue
Apr 21, 2020
Until we figure out why rollup not failing, see #1376 Note that these github actions appear to only test graphql-tools with graphql v15
Thanks again for awesome reproduction. Hoping to get a canary build out for you to test when #1368 lands. |
Also available with latest alpha, |
Closed by #1419. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
To start with, congratulations on the big
5.0.0
release, and thank you for all the hard work!I upgraded from
4.x.x
, and it looks like the current typings aren't working as intended for one small thing.Minimal Repro
Testing
I pulled down the repo locally and ran
./node_modules/.bin/tsc
, and noticed that the same compiler errors are also happening inmaster
.It looks like this likely wasn't caught by the unit tests because diagnostics are disabled in
ts-jest
.The issue can be seen by running
tsc
againstsrc/test/directives.test.ts
:The text was updated successfully, but these errors were encountered: