Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make applyRule() handly falsy replacements correctly #6037

Merged
merged 2 commits into from
Oct 10, 2023
Merged

fix: make applyRule() handly falsy replacements correctly #6037

merged 2 commits into from
Oct 10, 2023

Conversation

fiam
Copy link
Contributor

@fiam fiam commented Oct 3, 2023

if dataToReplace is false or 0, it will get ignored otherwise

Fixes #5817

🚨 IMPORTANT: Please do not create a Pull Request without creating an issue first.

Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of
the pull request.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant
motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Screenshots/Sandbox (if appropriate/relevant):

Adding links to sandbox or providing screenshots can help us understand more about this PR and take
action on it as appropriate

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can
reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Environment:

  • OS:
  • @graphql-mesh/...:
  • NodeJS:

Checklist:

  • I have followed the
    CONTRIBUTING doc and the
    style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose
the solution you did and what alternatives you considered, etc...

if dataToReplace is false or 0, it will get ignored otherwise

Fixes #5817
@changeset-bot
Copy link

changeset-bot bot commented Oct 3, 2023

⚠️ No Changeset found

Latest commit: 54248c1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Urigo
Copy link
Collaborator

Urigo commented Oct 3, 2023

thank you @fiam
could you add a test that covers this change?

@fiam
Copy link
Contributor Author

fiam commented Oct 3, 2023

Hello @Urigo - Thanks for taking a lot my PR. I looked around but I could not find any tests for this component. Should I just add a unit test for Interpolator?

@fiam
Copy link
Contributor Author

fiam commented Oct 3, 2023

Hello @Urigo - I've added a unit tests in a new file, PTAL

@ardatan ardatan merged commit 286aae5 into ardatan:master Oct 10, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In interpolator, applyRule function does not replace an argument if "dataToReplace" is 0
3 participants