Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): WebSocket request must be under req for envelop context #4304

Merged
merged 2 commits into from
Aug 15, 2022

Conversation

enisdenjo
Copy link
Collaborator

Description

In order to correctly assemble request headers and inject the ones from WebSocket, the request must be in the Node-like req object for envelop context factory.

https://github.com/Urigo/graphql-mesh/blob/79ade1b7fb8b72a4185fbd06438a44ed3fb4bd36/packages/runtime/src/get-mesh.ts#L143-L157

Fixes #4040

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Manually.

@changeset-bot
Copy link

changeset-bot bot commented Aug 15, 2022

🦋 Changeset detected

Latest commit: da46e17

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 39 packages
Name Type
@graphql-mesh/cli Patch
@graphql-mesh/container Patch
cloudflare-workers Patch
graphql-file-upload-example Patch
grpc-example Patch
grpc-reflection-example Patch
hasura-openbrewery-geodb Patch
hello-world-esm Patch
json-schema-hello-world Patch
json-schema-example Patch
json-schema-fhir Patch
json-schema-subscriptions Patch
mongoose-example Patch
mysql-employees Patch
mysql-rfam Patch
neo4j-example Patch
nextjs-apollo-example Patch
nextjs-sdk-example Patch
odata-microsoft-graph-example Patch
odata-msgraph-programmatic-ts Patch
odata-msgraph-programmatic Patch
odata-trippin-example Patch
javascript-wiki Patch
openapi-jira Patch
typescript-location-weather-example Patch
openapi-stackexchange Patch
openapi-stripe Patch
openapi-subscriptions Patch
openapi-youtrack Patch
postgres-geodb-example Patch
reddit-example Patch
country-info-example Patch
soap-demo Patch
soap-netsuite Patch
spacex-cfw Patch
chinook Patch
thrift-calculator Patch
type-merging-batching-example Patch
federation-gateway Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Aug 15, 2022

@enisdenjo is attempting to deploy a commit to the The Guild Team on Vercel.

A member of the Team first needs to authorize it.

@ardatan
Copy link
Owner

ardatan commented Aug 15, 2022

Thanks @enisdenjo!

@ardatan ardatan merged commit e9a251c into ardatan:master Aug 15, 2022
@enisdenjo enisdenjo deleted the request-in-req-for-ws branch August 15, 2022 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

connectionParams are not passed downstream anymore
2 participants