Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): Allow imports of external modules without default exports #2970

Closed

Conversation

ntziolis
Copy link
Contributor

Fixes #2968

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have followed the CONTRIBUTING doc and the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests and linter rules pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@changeset-bot
Copy link

changeset-bot bot commented Oct 13, 2021

⚠️ No Changeset found

Latest commit: 7e1e8d6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ntziolis ntziolis force-pushed the fix-build-non-default-imports branch from a50d87b to 7e1e8d6 Compare October 14, 2021 05:12
@ntziolis ntziolis changed the title Fix build non default imports Fix build enable non default imports for external modules Oct 14, 2021
@ntziolis ntziolis changed the title Fix build enable non default imports for external modules fix(build): Allow imports of external modules without default exports Oct 14, 2021
@ardatan ardatan force-pushed the master branch 2 times, most recently from 39e5048 to 7ef75ea Compare November 11, 2021 12:46
@ardatan ardatan force-pushed the master branch 6 times, most recently from faf42fd to a1c915a Compare December 8, 2021 11:37
@ardatan
Copy link
Owner

ardatan commented Jun 7, 2022

We no longer use default imports but lazy imports(so it loads entire module). I think this is solved in the latest version!

@ardatan ardatan closed this Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in mesh build when composer does not export defaults
2 participants