Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow lilac to be installed as a system package #160

Merged
merged 4 commits into from
Jul 23, 2020

Conversation

yan12125
Copy link
Member

Based on #78. Fixes #35. For archlinuxcn/repo#1651.

Some implementation notes

Tested scenarios:

  • ./lilac lilac-git from a git clone
  • lilac lilac-git with the package created by PKGBUILD above

/cc @Xuanwo @oldherl

@yan12125 yan12125 mentioned this pull request Jul 23, 2020
.gitignore Outdated
downloads/
eggs/
.eggs/
lib/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of these are pointless. Please don't add entries defensively. Changes are expected to be reviewed before committing so any unintential additions should be noticed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just remove those entries? Some of those entries are for generated file from python setup.py install, python setup.py sdist or python setup.py build. But I guess those setup.py commands will not appear during development of lilac?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setup.py generates only dist, sdist and build. I don't know where others come from.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are generated by IDEA and cloud be deleted if not used.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*.egg-info is generated from python setup.py egg_info (a command used by python setup.py build or python setup.py install).
.eggs is used to store packages specified in setup_requires if they are not installed beforehand.

In the updated commit (6f2479f), I keep entries that might be generated by setuptools and remove others.

Xuanwo and others added 4 commits July 23, 2020 22:38
A preparation step for packaging with setup.py - so that there will not
be /usr/lib/python3.8/site-packages/vendor.
To allow installation as a system package
@lilydjwg lilydjwg merged commit 107835f into archlinuxcn:master Jul 23, 2020
@yan12125 yan12125 deleted the add_setup branch July 23, 2020 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

write a setup.py
3 participants