-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow lilac to be installed as a system package #160
Conversation
.gitignore
Outdated
downloads/ | ||
eggs/ | ||
.eggs/ | ||
lib/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of these are pointless. Please don't add entries defensively. Changes are expected to be reviewed before committing so any unintential additions should be noticed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe just remove those entries? Some of those entries are for generated file from python setup.py install
, python setup.py sdist
or python setup.py build
. But I guess those setup.py commands will not appear during development of lilac?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
setup.py
generates only dist
, sdist
and build
. I don't know where others come from.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are generated by IDEA and cloud be deleted if not used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
*.egg-info
is generated from python setup.py egg_info
(a command used by python setup.py build
or python setup.py install
).
.eggs
is used to store packages specified in setup_requires
if they are not installed beforehand.
In the updated commit (6f2479f), I keep entries that might be generated by setuptools and remove others.
A preparation step for packaging with setup.py - so that there will not be /usr/lib/python3.8/site-packages/vendor.
To allow installation as a system package
Closes archlinuxcn#35 Closes archlinuxcn#78 For archlinuxcn/repo#1651
Based on #78. Fixes #35. For archlinuxcn/repo#1651.
Some implementation notes
~/.lilac/config.ini
is another path for the configuration fileconfig.ini.sample
is not handled bysetup.py
. I believe it should be installed in /usr/share/doc. However, someone may want to install this package withpython setup.py install --user
, so I leave it to downstream packagers. See PKGBUILD above as an example.Tested scenarios:
./lilac lilac-git
from a git clonelilac lilac-git
with the package created by PKGBUILD above/cc @Xuanwo @oldherl