Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a license statement #161

Closed
yan12125 opened this issue Jul 24, 2020 · 24 comments · Fixed by #170
Closed

Add a license statement #161

yan12125 opened this issue Jul 24, 2020 · 24 comments · Fixed by #170

Comments

@yan12125
Copy link
Member

To properly package lilac, a license statement is needed. There are two different levels of formality to do this:

  1. The less formal way - @lilydjwg picks some license and commits a LICENSE file

  2. The formal way. I consider chaging from no license ("All Rights Reserved") to some specific license as some kind of relicensing, so we need to establish an agreement from all previous contributors [1]. Here is an example: [2].

[1] https://github.com/archlinuxcn/lilac/graphs/contributors
[2] mpv-player/mpv#2033

@lilydjwg
Copy link
Member

I'd like to use GPLv3 for this project. What do others think?

@yan12125
Copy link
Member Author

I'm fine with using GPLv3 for my prior contributions.

@yan12125
Copy link
Member Author

Ping other contributors

@MarvelousBlack
@SilverRainZ
@VOID001
@Xuanwo
@a-wing
@attenuation
@axionl
@bennyyip
@cuihaoleo
@farseerfc
@felixonmars
@lilacbot (?)
@petronny
@renyuneyun
@yuyichao
@zsrkmyn

lilacbot has a commit c990c5d. @lilydjwg Is that authored by you?

@felixonmars
Copy link
Member

I'm fine with using GPLv3 for my prior contributions.

@petronny
Copy link
Member

petronny commented Jul 26, 2020

I'm fine with using GPLv3 for my prior contributions.

Checkbox for "I'm fine with using GPLv3 for my prior contributions.":

@yan12125
Copy link
Member Author

Checkbox for "I'm fine with using GPLv3 for my prior contributions.":

Well, most of packagers do not have write access to this repo, and thus modifying others' comments is not allowed.

@lilydjwg
Copy link
Member

lilacbot has a commit c990c5d. @lilydjwg Is that authored by you?

Yes. I forgot to explicitely use my name to commit on the build machine.

@farseerfc
Copy link
Member

I'm fine with using GPLv3 for my prior contributions.
(Explicit statement because I cannot change the checkbox)

@MarvelousBlack
Copy link
Member

I'm fine with using GPLv3 for my prior contributions.

4 similar comments
@Xuanwo
Copy link
Member

Xuanwo commented Jul 26, 2020

I'm fine with using GPLv3 for my prior contributions.

@yuyichao
Copy link
Member

I'm fine with using GPLv3 for my prior contributions.

@SilverRainZ
Copy link
Member

I'm fine with using GPLv3 for my prior contributions.

@bennyyip
Copy link
Contributor

I'm fine with using GPLv3 for my prior contributions.

@zsrkmyn
Copy link
Contributor

zsrkmyn commented Jul 29, 2020

I think there are only spaces and empty lines are left as my contributions. For these spaces and empty lines, I'm fine with GPLv3.

If there are anything else contributed by me, I'm fine with GPLv3 for them as well.

@yan12125
Copy link
Member Author

@zsrkmyn A large portion of your valuable contributions to usage.rst is still present in the latest commit (107835f) [1] and it does provide great information for those who are interested in lilac like me :)

[1] https://github.com/archlinuxcn/lilac/blame/107835f2fb9409a3356dbbea45e578210da39818/usage.rst

@axionl
Copy link
Member

axionl commented Aug 6, 2020

I'm fine with using GPLv3 for my prior contributions.

3 similar comments
@a-wing
Copy link
Member

a-wing commented Aug 6, 2020

I'm fine with using GPLv3 for my prior contributions.

@VOID001
Copy link
Member

VOID001 commented Aug 6, 2020

I'm fine with using GPLv3 for my prior contributions.

@oowl
Copy link
Member

oowl commented Aug 9, 2020

I'm fine with using GPLv3 for my prior contributions.

@yan12125
Copy link
Member Author

yan12125 commented Sep 3, 2020

@renyuneyun could you have a look at this?

@renyuneyun
Copy link
Contributor

I'm fine with using GPLv3 for my prior contributions.

(Sorry I didn't check github notifications, and the emails went to a strange place...)

@yan12125
Copy link
Member Author

Sorry I didn't check github notifications, and the emails went to a strange place...

No problem!


@cuihaoleo mind to have a look? Your prior contribution is 1f81d45, and it's still used in today's lilac:

lilac/lilac2/api.py

Lines 425 to 440 in f7f64db

def _download_aur_pkgbuild(name: str) -> List[str]:
content = io.BytesIO(_try_aur_url(name))
files = []
with tarfile.open(
name=name+".tar.gz", mode="r:gz", fileobj=content
) as tarf:
for tarinfo in tarf:
basename, remain = os.path.split(tarinfo.name)
if basename == '':
continue
if remain in ('.AURINFO', '.SRCINFO', '.gitignore'):
continue
tarinfo.name = remain
tarf.extract(tarinfo)
files.append(remain)
return files
.

@cuihaoleo
Copy link
Member

I'm fine with using GPLv3 for my prior contributions!!!

yan12125 pushed a commit to yan12125/lilac that referenced this issue Dec 31, 2020
@yan12125 yan12125 mentioned this issue Dec 31, 2020
@yan12125
Copy link
Member Author

Thanks everyone for the agreement! Now that it is OK to relicense this project as GPLv3: #170.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.