Remove unused Any instances from TYPE_CHECKING blocks #2878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will make it easier to start removing more Any instances from the codebase.
svartkanin
reviewed
Nov 19, 2024
| @@ -85,10 +85,17 @@ warn_unreachable = true | |||
| warn_unused_configs = true | |||
| warn_unused_ignores = true | |||
|
|
|||
| [[tool.mypy.overrides]] | |||
| module = "archinstall.default_profiles.applications.*" | |||
| disallow_any_explicit = true | |||
There was a problem hiding this comment.
@correctmost will this prevent any future use of the _: Any?
We're using that for translations, so it's likely we'll need it again
There was a problem hiding this comment.
That setting will cause mypy to warn about the use of Any in that directory, so we'll have to use something like this instead:
_: Callable[[str], DeferredTranslation]I plan on changing the remaining _ declarations to use Callable instead of Any, but I won't be able to do that until the weekend.
There was a problem hiding this comment.
Great work overall with these quality improvements, it's understated how much we appreciated it I think!
There was a problem hiding this comment.
Thank you--and thanks for being receptive to the changes, too :)
svartkanin
approved these changes
Nov 19, 2024
castillofrancodamian
pushed a commit
to castillofrancodamian/archinstall
that referenced
this pull request
Dec 21, 2024
This will make it easier to start removing more Any instances from the codebase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description:
This will make it easier to start removing more
Anyinstances from the codebase.Some of the regressions in 3.0.0 are not being caught by mypy because of the prevalence of
Anyin the code.