Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 2337 (and similar) - Ignore existing partitions #2342

Merged
merged 2 commits into from
Mar 7, 2024

Conversation

svartkanin
Copy link
Collaborator

@svartkanin svartkanin commented Jan 21, 2024

This fixes #2337, #2316, #2324, #2304 and #2317

  • The formatting validation is only applicable to partitions that should be created or modified
  • Creating BTRFS volumes is only applicable if the partition should be created or modified

@svartkanin svartkanin requested a review from Torxed as a code owner January 21, 2024 04:10
@codefiles
Copy link
Contributor

My proposed fix in #1971 (comment):

Filtering the partitions to be validated to only partitions with a status of modify (ModificationStatus.Modify) or create (ModificationStatus.Create) should fix this unless there is a purpose behind validating partitions with a status of existing (ModificationStatus.Exist) or delete (ModificationStatus.Delete).

You credited my investigative work from this comment in #2031 but maybe missed the proposed fix. Thanks for taking care of this.

@svartkanin
Copy link
Collaborator Author

I missed that conversation there somehow, thanks for the analysis and the confirmation that this is the right path

@svartkanin svartkanin changed the title Fix 2337 Fix 2337 (and similar) - Ignore existing partitions Jan 28, 2024
@Torxed Torxed merged commit 21dd295 into archlinux:master Mar 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"ValueError: Crypto luks cannot be set as a filesystem type" when attempting to delete crypto_LUKS partition
3 participants