Skip to content
This repository has been archived by the owner on Jun 13, 2023. It is now read-only.

[ruby] Upgrade rubocop-rspec to version 2.4.0 #214

Merged
merged 1 commit into from
Jul 13, 2021

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Jun 10, 2021

👉 This PR is queued up to get rebased by Depfu

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop-rspec (~> 2.3.0 → ~> 2.4.0) · Repo · Changelog

Release Notes

2.4.0

  • Update RSpec/FilePath to check suffix when given a non-constant top-level node (e.g. features). (@topalovic)
  • Add missing documentation for single_statement_only style of RSpec/ImplicitSubject cop. (@tejasbubane)
  • Fix an exception in DescribedClass when accessing a constant on a variable in a spec that is nested in a namespace. (@rrosenblum)
  • Add new RSpec/IdenticalEqualityAssertion cop. (@tejasbubane)
  • Add RSpec/Rails/AvoidSetupHook cop. (@paydaylight)
  • Fix false negative in RSpec/ExpectChange cop with block style and chained method call. (@tejasbubane)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 18 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label Jun 10, 2021
@codecov
Copy link

codecov bot commented Jun 10, 2021

Codecov Report

Merging #214 (31ab09f) into main (1fa133e) will not change coverage.
The diff coverage is n/a.

❗ Current head 31ab09f differs from pull request most recent head d52b94c. Consider uploading reports for the commit d52b94c to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##              main      #214   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines           33        33           
=========================================
  Hits            33        33           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fa133e...d52b94c. Read the comment docs.

@ruebot
Copy link
Member

ruebot commented Jul 13, 2021

@​depfu rebase

@depfu depfu bot force-pushed the depfu/update/rubocop-rspec-2.4.0 branch from c59d191 to d52b94c Compare July 13, 2021 16:47
@ruebot ruebot merged commit 775e94f into main Jul 13, 2021
@depfu depfu bot deleted the depfu/update/rubocop-rspec-2.4.0 branch July 13, 2021 17:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant