This repository has been archived by the owner on Jun 13, 2023. It is now read-only.
[ruby] Upgrade rubocop to version 1.12.0 #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![depfu[bot]](https://avatars.githubusercontent.com/in/715?s=60&v=4){kind=small}
Codecov Report
@@ Coverage Diff @@
## main #191 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 34 34
=========================================
Hits 34 34 Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.
What changed?
✳️ rubocop (~> 1.11.0 → ~> 1.12.0) · Repo · Changelog
Release Notes
1.12.0
Does any of this look wrong? Please let us know.
Commits
See the full diff on Github. The new version differs by 72 commits:
Cut 1.12Update Changelog[Fix #9622] Fixed `Style/BisectedAttrAccessor` autocorrection to handle multiple bisected attrs in the same macro.Merge pull request #9632 from koic/fix_a_false_positive_for_style_access_modifier_declarationsMerge pull request #9633 from koic/fix_incorrect_autocorrect_for_lint_number_conversionFix an incorrect auto-correct for `Lint/NumberConversion`[Fix #5953] Fix a false positive for `Style/AccessModifierDeclarations`Refactor CommentConfig[Fix #9621] Add `consistent` style to `Lint/SymbolConversion` to require all symbol keys in a hash to use the same convention.Fix an incorrect auto-correct for `Style/RedundantReturn`Add names for department to RegistryAdd department check to RegistryDocument cases where parens are accepted even in `omit_parentheses` styleAllow parentheses in operator method calls for `Style/MethodCallWithArgsParentheses`Calls with braces in interpolation for Style/MethodCallWithArgsParenthesesAllow parentheses in yield arguments for `Style/MethodCallWithArgsParentheses`[Fix #9627] Fix an incorrect auto-correct for `Style/StructInheritance`Add `StyleGuide` for `Style/StringChars`Merge pull request #9619 from dvandersluis/fix/indentation-width-rescueFix infinite loop between `Layout/IndentationWidth` and `Layout/RescueEnsureAlignment` autocorrection.[Fix #9613] Fix a false positive for `Style/RedundantSelf`Merge pull request #9618 from dvandersluis/issue/9617[Fix #9617] Disable suggested extensions when using the `--stdin` option.Add new `Style/StringChars` copMerge pull request #9616 from koic/fix_incorrect_autocorrect_for_style_eval_with_locationFix an incorrect auto-correct for `Style/EvalWithLocation`[Fixes #9487] Mark Naming/MemoizedInstanceVariableName as unsafeReplace CommentConfig#directive_parts with DirectiveComment instanceReplace useless public DirectiveComment#cops with private method[Fix #9606] Fix an error for `Layout/IndentationConsistency`Fix a build errorAllow excluding some constants from Style/Documentation[Fix #9603] Fix a false positive for `Style/SoleNestedConditional`[Fix #9601] Make `Style/RedundantBegin` aware of `begin` blocks around memoization[Fix #9599] Fix an error for `Style/CaseLikeIf`Merge pull request #9598 from kachick/fix-shareable_constant_valueFix RuboCop::MagicComment#valid_shareable_constant_value?Merge pull request #9597 from koic/ci_against_jruby_9_2_16_0Revert "Workaround for JRuby 9.2.14.0"Revert "Workaround for JRuby 9.2.15.0 regression"Add spec for CommentConfig#comment_only_line?[Fix #9593] Fix an error when processing a directory is named `{}`Merge pull request #9585 from koic/use_cop_base_api_for_style_rescue_modifierMerge pull request #9587 from dvandersluis/issue/9586[Fix #9586] Update `Naming/RescuedExceptionsVariableName` to not register on inner rescues when nested.Tweak a linkUse `Cop::Base` API for `Style/RescueModifier`Add spec for CommentConfig#extra_enabled_comments[Fix #9582] Fix incorrect auto-correct for `Style/ClassEqualityComparison`[Fix #9558] Fix inconsistency when dealing with URIs that are wrapped in single quotes vs double quotes.Add spec for CommentConfig#cop_disabled_line_rangesImprove readability of CommentConfig spec source (#9577)Remove useless constants from CommentConfigAdd single_line? checker to DirectiveCommentAdd before_comment helper to DirectiveCommentDetect directive comments using DirectiveCommentMove directive comment pattern to DirectiveCommentMerge pull request #9576 from koic/use_cop_base_api_for_alignmentMerge pull request #9579 from despo/fix-typo--use-correct-articleFix typo in Style::RedundantSelf documentationUse `Cop::Base` API for `Alignment`Use https for links to suggested extensions.Correct stray rubocop-hq reference.Use `Cop::Base` API for `Style/HashSyntax`Fix an error for `Style/ClassMethodsDefinitions`Fix a build errorMerge pull request #9436 from tejasbubane/fix-9429Remove a redundant condition for `Style/TrailingBodyOnMethodDefinition`Add example for `Style/TrailingBodyOnMethodDefinition`Add AllowNil config option to Lint/SuppressedException (#9546)[Fix #9551] Fix a false positive for `Style/UnlessLogicalOperators`Switch back the docs version to masterDepfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with
@depfu rebase.All Depfu comment commands