Skip to content
This repository has been archived by the owner on Jun 13, 2023. It is now read-only.

[ruby] Upgrade rubocop to version 1.7.0 #172

Merged
merged 1 commit into from
Jan 7, 2021
Merged

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Dec 26, 2020

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop (~> 1.6.1 → ~> 1.7.0) · Repo · Changelog

Release Notes

1.7.0

New features

  • #9260: Support auto-correction for Style/MultilineMethodSignature. (@koic)
  • #9282: Make Style/RedundantFreeze and Style/MutableConstant cops aware of frozen regexp and range literals when using Ruby 3.0. (@koic)
  • #9223: Add new Lint/AmbiguousAssignment cop. (@fatkodima)
  • #9243: Support auto-correction for Style/CommentedKeyword. (@koic)
  • #9283: Add new Style/HashExcept cop. (@koic)
  • #9231: Add new Layout/SpaceBeforeBrackets cop. (@koic)

Bug fixes

  • #9232: Fix Style/SymbolProc registering wrong offense when using a symbol numbered block argument greater than 1, i.e. [[1, 2]].map { _2.succ }. (@tdeo)
  • #9274: Fix error in Metrics/ClassLength when the class only contains comments. (@dvandersluis)
  • #9213: Fix a false positive for Style/RedanduntFreeze when using Array#*. (@koic)
  • #9279: Add support for endless methods to Style/MethodCallWithArgsParentheses. (@dvandersluis)
  • #9245: Fix Lint/AmbiguousRegexpLiteral when given a match_with_lvasgn node. (@dvandersluis)
  • #9276: Add support for endless methods to Style/SingleLineMethods. (@dvandersluis)
  • #9225: Fix Style/LambdaCall ignoring further offenses after opposite style is detected. (@sswander)
  • #9234: Fix the error for Style/KeywordParametersOrder and make it aware of block keyword parameters. (@koic)
  • #8938: Fix some ConfigurableEnforcedStyle cops to output Exclude file lists in --auto-gen-config runs. (@h-lame)
  • #9257: Fix false positive for Style/SymbolProc when the block uses a variable from outside the block. (@dvandersluis)
  • #9251: Fix extracted cop warning when the extension is loaded using --require. (@dvandersluis)
  • #9244: When a cop defined in an extension is explicitly enabled, ensure that it remains enabled. (@dvandersluis)
  • #8046: Fix an error for Layout/HeredocArgumentClosingParenthesis when there is an argument between a heredoc argument and the closing paretheses. (@koic)
  • #9261: Fix an incorrect auto-correct for Style/MultilineWhenThen when one line for multiple condidate values of when statement. (@makicamel)
  • #9258: Fix calculation of cop department for nested departments. (@mvz)
  • #9277: Fix Layout/EmptyLineBetweenDefs error with endless method definitions. (@dvandersluis)
  • #9278: Update Style/MethodDefParentheses to ignore endless method definitions since parentheses are always required. (@dvandersluis)

Changes

  • #9212: Make Style/RedundantArgument aware of String#chomp and String#chomp!. (@koic)
  • #8482: Allow simple math for Lint/BinaryOperatorWithIdenticalOperands cop. (@fatkodima)
  • #9237: Add IgnoredPatterns configuration to Lint/UnreachableLoop to allow for block methods that share a name with an Enumerable method. (@dvandersluis)
  • #9206: Allow extensions to disable cop obsoletions. (@dvandersluis)
  • #9262: Update Style/CollectionMethods to be handle additional arguments and methods that accept a symbol instead of a block. (@dvandersluis)
  • #9235: Allow --only and --except to be able to properly qualify cops added by require. (@dvandersluis)
  • #9205: Update Naming/MemoizedInstanceVariableName to handle dynamically defined methods. (@dvandersluis)
  • #9285: Add AllowPercentLiteralArrayArgument option for Lint/RedundantSplatExpansion to enable the option by default. (@koic)
  • #9208: Use Array#bsearch instead of Array#include? to detect hidden files. (@dark-panda)
  • #9228: Suppress any config warnings for rubocop -V. (@dvandersluis)
  • #9193: Add IgnoreLiteralBranches and IgnoreConstantBranches options to Lint/DuplicateBranch. (@dvandersluis)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label Dec 26, 2020
@codecov
Copy link

codecov bot commented Dec 26, 2020

Codecov Report

Merging #172 (b716163) into main (fa1403d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #172   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines           34        34           
=========================================
  Hits            34        34           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa1403d...b716163. Read the comment docs.

@ruebot ruebot merged commit 62cb78b into main Jan 7, 2021
@depfu depfu bot deleted the depfu/update/rubocop-1.7.0 branch January 7, 2021 15:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant