Skip to content
This repository has been archived by the owner on Jun 13, 2023. It is now read-only.

[ruby] Upgrade rubocop to version 0.93.0 #149

Merged
merged 1 commit into from
Oct 9, 2020
Merged

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Oct 9, 2020

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop (~> 0.92.0 → ~> 0.93.0) · Repo · Changelog

Release Notes

0.93.0

New features

Bug fixes

  • #8810: Fix multiple offense detection for Style/RaiseArgs. (@pbernays)
  • #8151: Fix a false positive for Lint/BooleanSymbol when used within %i[...]. (@fatkodima)
  • #8809: Fix multiple offense detection for Style/For. (@pbernays)
  • #8801: Fix Layout/SpaceAroundEqualsInParameterDefault only registered once in a line. (@rdunlop)
  • #8514: Correct multiple Style/MethodDefParentheses per file. (@rdunlop)
  • #8825: Fix crash in Style/ExplicitBlockArgument when code is called outside of a method. (@ghiculescu)
  • #8718: Fix undefined methods of pseudo location. (@ybiquitous)
  • #8354: Detect regexp named captures in Style/CaseLikeIf cop. (@dsavochkin)
  • #8821: Fix an incorrect autocorrect for Style/NestedTernaryOperator when using a nested ternary operator expression with no parentheses on the outside. (@koic)
  • #8834: Fix a false positive for Style/ParenthesesAsGroupedExpression when method argument parentheses are omitted and hash argument key is enclosed in parentheses. (@koic)
  • #8830: Fix bad autocorrect of Style/StringConcatenation when string includes double quotes. (@tleish)
  • #8807: Fix a false positive for Style/RedundantCondition when using assignment by hash key access. (@koic)
  • #8848: Fix a false positive for Style/CombinableLoops when using the same method with different arguments. (@dvandersluis)
  • #8843: Fix an incorrect autocorrect for Lint/AmbiguousRegexpLiteral when sending method to regexp literal receiver. (@koic)
  • #8842: Save actual status to cache, except corrected. (@hatkyinc2)
  • #8835: Fix an incorrect autocorrect for Style/RedundantInterpolation when using string interpolation for non-operator methods. (@koic)
  • #7495: Example for Lint/AmbiguousBlockAssociation cop. (@AllanSiqueira)
  • #8855: Fix an error for Layout/EmptyLinesAroundAccessModifier and Style/AccessModifierDeclarations when using only access modifier. (@koic)

Changes

  • #8803: (Breaking) RegexpNode#parsed_tree now processes regexps including interpolation (by blanking the interpolation before parsing, rather than skipping). (@owst)
  • #8625: Improve Style/RedundantRegexpCharacterClass and Style/RedundantRegexpEscape by using regexp_parser gem. (@owst)
  • #8646: Faster find of all files in TargetFinder class which improves initial startup speed. (@tleish)
  • #8102: Consider class length instead of block length for Struct.new. (@tejasbubane)
  • #7408: Make Gemspec/RequiredRubyVersion cop aware of Gem::Requirement. (@tejasbubane)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 59 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label Oct 9, 2020
@codecov
Copy link

codecov bot commented Oct 9, 2020

Codecov Report

Merging #149 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #149   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines           34        34           
=========================================
  Hits            34        34           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5f7aec...0072e7d. Read the comment docs.

@ruebot ruebot merged commit df7b60c into main Oct 9, 2020
@depfu depfu bot deleted the depfu/update/rubocop-0.93.0 branch October 9, 2020 18:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant