Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create unit tests for Issue #50 (ExtractPopularImages) #93

Merged
merged 1 commit into from
Oct 13, 2017
Merged

Conversation

greebie
Copy link
Contributor

@greebie greebie commented Oct 13, 2017

Unit Test Cover for Issue #50


GitHub issue(s):

#50

What does this Pull Request do?

Increases test coverage.

How should this be tested?

Travis & Codecov

Additional Notes:

NA

Interested parties

Tag (@ mention) interested parties.

Thanks in advance for your help with the Archives Unleashed Toolkit!

@codecov
Copy link

codecov bot commented Oct 13, 2017

Codecov Report

Merging #93 into master will increase coverage by 2.19%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #93      +/-   ##
==========================================
+ Coverage   55.66%   57.85%   +2.19%     
==========================================
  Files          41       41              
  Lines         821      821              
  Branches      146      146              
==========================================
+ Hits          457      475      +18     
+ Misses        320      296      -24     
- Partials       44       50       +6
Impacted Files Coverage Δ
...ala/io/archivesunleashed/spark/rdd/RecordRDD.scala 38.88% <0%> (+1.85%) ⬆️
...nleashed/spark/matchbox/ExtractPopularImages.scala 100% <0%> (+100%) ⬆️
.../archivesunleashed/spark/matchbox/ComputeMD5.scala 100% <0%> (+100%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23d0cb4...5fa3472. Read the comment docs.

@ruebot ruebot merged commit 065fb6f into master Oct 13, 2017
@ruebot ruebot deleted the Issue-50 branch October 13, 2017 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants