Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve coverage for TweetUtils #90

Merged
merged 3 commits into from
Oct 7, 2017
Merged

Improve coverage for TweetUtils #90

merged 3 commits into from
Oct 7, 2017

Conversation

greebie
Copy link
Contributor

@greebie greebie commented Oct 6, 2017

Add Test for TweetUtils


GitHub issue(s):

If you are responding to an issue, please mention their numbers below.

#54

What does this Pull Request do?

A brief description of what the intended result of the Pull Request (PR) will be, what problem it solves, technical details, and any possible side effects.

Example:

  • Increases test coverage
  • Fixes TweetUtil to accept verified user input from a Twitter JSON stream

How should this be tested?

Codecov and Travis should work to cover test.
However, trying out an export from a tweet sample would confirm it works properly.

Additional Notes:

Any additional information that you think would be helpful when reviewing this PR.

TweetUtils has a "isVerifiedUser()" function that was merely double-checking for user. I switched this to accept a value for a "verified" (in Twitter's terms) user.

Interested parties

@ruebot

Thanks in advance for your help with the Archives Unleashed Toolkit!

@codecov
Copy link

codecov bot commented Oct 6, 2017

Codecov Report

Merging #90 into master will increase coverage by 1.21%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #90      +/-   ##
==========================================
+ Coverage   49.81%   51.03%   +1.21%     
==========================================
  Files          41       41              
  Lines         821      821              
  Branches      147      146       -1     
==========================================
+ Hits          409      419      +10     
+ Misses        371      360      -11     
- Partials       41       42       +1
Impacted Files Coverage Δ
.../archivesunleashed/spark/matchbox/TweetUtils.scala 90.9% <100%> (+90.9%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22c5ba0...9ddaf5a. Read the comment docs.

@ruebot
Copy link
Member

ruebot commented Oct 7, 2017

nice work @greebie!

@ruebot ruebot merged commit 8a098c7 into master Oct 7, 2017
@ruebot ruebot deleted the Issue-54 branch October 7, 2017 00:43
@ianmilligan1
Copy link
Member

51.03% codecov 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants