Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Test Coverage for #55, #56, #57, #58, #59, #60, #61, #62, #63, #64 & #66 #87

Merged
merged 11 commits into from
Oct 6, 2017

Conversation

greebie
Copy link
Contributor

@greebie greebie commented Oct 6, 2017

Improve Test Coverage

GitHub issue(s):

If you are responding to an issue, please mention their numbers below.

#55, #56, #57, #58, #59, #60, #61, #62, #63, #64 & #66

What does this Pull Request do?

Improves test coverage.

How should this be tested?

CodeCov + Travis should cover it.

Additional Notes:

Interested parties

@ruebot @lintool @ianmilligan1

Thanks in advance for your help with the Archives Unleashed Toolkit!

@codecov
Copy link

codecov bot commented Oct 6, 2017

Codecov Report

Merging #87 into master will increase coverage by 2.31%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #87      +/-   ##
==========================================
+ Coverage   46.16%   48.47%   +2.31%     
==========================================
  Files          41       41              
  Lines         821      821              
  Branches      147      147              
==========================================
+ Hits          379      398      +19     
+ Misses        395      382      -13     
+ Partials       47       41       -6
Impacted Files Coverage Δ
...rchivesunleashed/spark/matchbox/ExtractLinks.scala 100% <0%> (+16.66%) ⬆️
...esunleashed/spark/matchbox/ExtractImageLinks.scala 100% <0%> (+20%) ⬆️
...chivesunleashed/spark/matchbox/ExtractDomain.scala 100% <0%> (+22.22%) ⬆️
...archivesunleashed/spark/matchbox/StringUtils.scala 100% <0%> (+25%) ⬆️
...vesunleashed/spark/matchbox/RemoveHttpHeader.scala 100% <0%> (+50%) ⬆️
...la/io/archivesunleashed/spark/utils/JsonUtil.scala 85.71% <0%> (+85.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aac74d9...661c69c. Read the comment docs.

@ruebot
Copy link
Member

ruebot commented Oct 6, 2017

@greebie really nice work here! Do you want to go for 100% on JsonUtil.scala or come back to that later? Either way to go is fine by me, and I'm happy to merge this as it is now.

@greebie
Copy link
Contributor Author

greebie commented Oct 6, 2017

Thanks @ruebot If you can merge that now, I'd appreciate it. Then I'll have branch names that use the issue number to make it easier to see each one separately. Better that way since these are more patches than improvements.

@ruebot ruebot merged commit c8b7d2e into master Oct 6, 2017
@ruebot ruebot deleted the Issue-63 branch October 6, 2017 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants