Filter or filedesc and dns records from arcs. #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Resolves #516 - add removeFiledesc method, and apply it - update tests
Codecov Report
@@ Coverage Diff @@
## main #517 +/- ##
============================================
+ Coverage 88.83% 88.97% +0.14%
Complexity 57 57
============================================
Files 43 43
Lines 1012 1025 +13
Branches 85 85
============================================
+ Hits 899 912 +13
Misses 74 74
Partials 39 39 |
ianmilligan1
approved these changes
May 12, 2021
There was a problem hiding this comment.
Works like a charm; results as per the tests I ran in #516 now display records but no filedesc.
+----------+----------------------------------------------------------------------------------+
|crawl_date|url |
+----------+----------------------------------------------------------------------------------+
|20060622 |http://www.gca.ca/indexcms/?organizations&orgid=27 |
|20060622 |http://www.ppforum.com/en/speeches/index.asp?theme=all&year=2003 |
|20060622 |http://www.nosharia.com/telgraaf,%20nedeland_files/image010.gif |
|20060622 |http://www.canadianlandmine.org/french/french/n1kd.cfm |
|20060622 |http://canadianactionparty.ca/temp/Important_Memos/Some_facts_about_the_Census.doc|
|20060622 |http://coat.ncf.ca/our_magazine/links/53/smith_a.jpg |
|20060622 |http://communist-party.ca/calendar/cal_week.php?op=week&date=2006-08-18&catview=0 |
|20060622 |http://www.nawl.ca/ns/en/documents/Pub_Brief_Antiterror01_en.doc |
|20060622 |http://www.conservative.ca/EN/1018/ |
|20060622 |http://www.canadafirst.net/immi_crime/canada_terrorist_destination.html |
+----------+----------------------------------------------------------------------------------+
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub issue(s): #516
What does this Pull Request do?
Filter or filedesc and dns records from arcs.
urllist #516removeFiledescmethod, and apply itHow should this be tested?
Tests should take care of it, but @ianmilligan1 if you want to run your local tests you did in #516 again, that'd be helpful.