-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove RDD suffixes on file, class, and object names. #479
Conversation
- Remove all the RDD suffixes added previously - Rename presentationProgramFiles to presentationProgram (Scala) - Rename wordProcessorFiles to wordProcessor (Scala) - Rename image_graph to imagegraph (Python) - Rename textFiles to textfiles (Scala) - Rename text_files to textfiles (Python) - Rename files all affected files as needed - Update tests as needed
Documentation updates are over here. They'll get in the website when the time comes. |
Codecov Report
@@ Coverage Diff @@
## master #479 +/- ##
==========================================
- Coverage 83.88% 83.69% -0.20%
==========================================
Files 44 43 -1
Lines 1297 1245 -52
Branches 250 239 -11
==========================================
- Hits 1088 1042 -46
Misses 80 80
+ Partials 129 123 -6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I caught a name inconsistency?
src/main/scala/io/archivesunleashed/matchbox/GetExtensionMime.scala
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
GitHub issue(s): #468
What does this Pull Request do?
Remove RDD suffixes on file, class, and object names.
How should this be tested?
Additional Notes: