-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dataframe matchbox Implementations #387
Conversation
Codecov Report
@@ Coverage Diff @@
## master #387 +/- ##
==========================================
- Coverage 76.7% 75.97% -0.74%
==========================================
Files 41 41
Lines 1451 1469 +18
Branches 268 274 +6
==========================================
+ Hits 1113 1116 +3
- Misses 221 236 +15
Partials 117 117 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple formatting and comment prose tweaks.
Tested, and works as expected. I'll get a PR in for the docs.
@@ -26,6 +26,7 @@ import java.util.Base64 | |||
/** | |||
* UDFs for data frames. | |||
*/ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove this blank line.
@@ -49,4 +49,29 @@ object ExtractDate { | |||
"" | |||
} | |||
} | |||
|
|||
/** Extracts the wanted date component from a date (for DataFrames). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's reword this to:
Extracts a provided date component from a date (for DataFrames).
* Updates for archivesunleashed/aut#387 * Missed some in #24
Dataframe Implementations for ExtractDate, DetectLanguage and ExtarctBoilerpipeText
For Testing:
ExtractDate:
DetectLanguage:
ExtarctBoilerpipeText: