-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align NER output to WANE format #361
Conversation
Codecov Report
@@ Coverage Diff @@
## master #361 +/- ##
=========================================
+ Coverage 76.25% 76.36% +0.1%
=========================================
Files 40 40
Lines 1411 1413 +2
Branches 267 268 +1
=========================================
+ Hits 1076 1079 +3
+ Misses 219 217 -2
- Partials 116 117 +1 |
@ianmilligan1 it'll be awhile before I get back to writing the class to take care of the last bit of the implementation. Should we just merge what we have now, and come back around to the last bit later? |
Yep, that makes complete sense to me. I can test one last time once the branch is updated and marked ready for review. |
@ianmilligan1 awesome. when you're ready to merge, let me know and I'll clean up the commit message since it is really bad right now 😬 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Builds nicely locally, and output looks great on a sample ARC. Do you want to provide a clean commit message and then I can merge, @ruebot ?
Sorry, I had a local commit I never pushed. Here's a commit message when you're ready:
|
Codecov Report
@@ Coverage Diff @@
## master #361 +/- ##
=========================================
+ Coverage 76.25% 76.36% +0.1%
=========================================
Files 40 40
Lines 1411 1413 +2
Branches 267 268 +1
=========================================
+ Hits 1076 1079 +3
+ Misses 219 217 -2
- Partials 116 117 +1 |
@ianmilligan1 thanks! I'll have a PR for aut-docs-new shortly. |
GitHub issue(s): #297
What does this Pull Request do?
How should this be tested?
Should produce output like this:
Additional Notes: