Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean-up pom.xml to remove plugin warnings; resolves #273. #274

Merged
merged 1 commit into from
Oct 9, 2018
Merged

Conversation

ruebot
Copy link
Member

@ruebot ruebot commented Oct 5, 2018

GitHub issue(s): #273

What does this Pull Request do?

  • Clean-up pom.xml to remove plugin warnings; resolves Maven build warning during release #273.
  • The removed javadoc.plugin.version is because there were actually two of them in that section with two different versions. 🤯

How should this be tested?

  • TravisCI should pass.
  • Local build should not show previous warnings (as shown in Maven build warning during release #273) during this build or
    • mvn release:clean
    • mvn release:prepare -DreleaseVersion=0.17.1 -DdevelopmentVersion=0.17.2-SNAPSHOT -DautoVersionSubmodules=true -DpushChanges=false

Additional Notes:

Not sure how to have others test this since you might need signing keys setup, and a ~/.m2/settings.xml setup as described here

@ruebot ruebot requested review from lintool and ianmilligan1 October 5, 2018 16:24
@codecov-io
Copy link

codecov-io commented Oct 5, 2018

Codecov Report

Merging #274 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #274   +/-   ##
=======================================
  Coverage   70.36%   70.36%           
=======================================
  Files          41       41           
  Lines        1046     1046           
  Branches      192      192           
=======================================
  Hits          736      736           
  Misses        244      244           
  Partials       66       66

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9796f50...bfeddec. Read the comment docs.

Copy link
Member

@ianmilligan1 ianmilligan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested using mvn release:clean and mvn release:prepare -DreleaseVersion=0.17.1 -DdevelopmentVersion=0.17.2-SNAPSHOT -DautoVersionSubmodules=true -DpushChanges=false, builds fine w/o the error messages as noted in #273.

Copy link
Member

@lintool lintool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ianmilligan1 ianmilligan1 merged commit f19dc9a into archivesunleashed:master Oct 9, 2018
@ruebot ruebot deleted the issue-273 branch October 9, 2018 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maven build warning during release
4 participants