Add deprecation warnings to outmoded Arc and Warc formats. #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #140 +/- ##
==========================================
+ Coverage 67.7% 67.74% +0.04%
==========================================
Files 38 38
Lines 774 775 +1
Branches 143 143
==========================================
+ Hits 524 525 +1
Misses 201 201
Partials 49 49
Continue to review full report at Codecov.
|
ruebot
requested changes
Dec 6, 2017
|
|
||
| /** | ||
| * @deprecated as of 0.11.0 and will be removed | ||
| * in a future release. Use GenericArchiveRecordWritable (0.11.0) or |
| @@ -14,6 +14,12 @@ | |||
| * See the License for the specific language governing permissions and | |||
| * limitations under the License. | |||
| */ | |||
|
|
|||
| /** | |||
| * Features here have been deprecated as of 0.11.0 and will be replaced | |||
There was a problem hiding this comment.
Version number should be 0.12.0 since 0.11.0 is already out, and it was not marked as deprecated in it. Once this gets merged in, we resolve #124, and figure out the Docker build issue, we'll cut 0.12.0.
|
|
||
| /** | ||
| * @deprecated as of 0.11.0 and will be removed | ||
| * in a future release. Use WacGenericArchiveInputFormat (0.11.0) or |
| @@ -14,6 +14,12 @@ | |||
| * See the License for the specific language governing permissions and | |||
| * limitations under the License. | |||
| */ | |||
|
|
|||
| /** | |||
| * Features here have been deprecated as of 0.11.0 and will be replaced | |||
|
|
||
| /** | ||
| * @deprecated as of 0.11.0 and will be removed | ||
| * in a future release. Use WacGenericArchiveInputFormat (0.11.0) or |
| /** | ||
| * @deprecated as of 0.11.0 and will be removed | ||
| * in a future release. Use WacGenericArchiveInputFormat (0.11.0) or | ||
| * WacArchiveInputFormat (future releases) instead. |
| /** | ||
| * @deprecated as of 0.11.0 and will be removed | ||
| * in a future release. Use WacGenericArchiveInputFormat (0.11.0) or | ||
| * WacArchiveInputFormat (future releases) instead. |
| /** | ||
| * @deprecated as of 0.11.0 and will be removed | ||
| * in a future release. Use GenericArchiveRecordWritable (0.11.0) or | ||
| * ArchiveRecordWritable (future releases) instead. |
There was a problem hiding this comment.
Will do, but to clarify, ArchiveRecordWritable will not exist until the changes in the RefactorLoader have been implemented.
Change 0.11 to 0.12.
I'm good to go once @lintool is good to go. |
ruebot
approved these changes
Dec 6, 2017
|
@greebie can you update, and then I'll merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Deprecation warnings to Arc & Warc Writeable and Input Formats
GitHub issue(s):
Related to discussion in #80.
What does this Pull Request do?
Add deprecation warnings to unused Warc and Arc java files.
How should this be tested?
N/A
Additional Notes:
@lintool suggests that this code has other potential purposes in #102 (comment) so I recommend having his okay before merging. Alternately, it may be good to have a nice place to store this code somewhere.
5bc95a1 contains working code for removal in the next cycle.
Interested parties
@lintool
Thanks in advance for your help with the Archives Unleashed Toolkit!