Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pom.xml cruft; Partially resolves #111. #112

Merged
merged 1 commit into from
Nov 14, 2017
Merged

Conversation

ruebot
Copy link
Member

@ruebot ruebot commented Nov 11, 2017

GitHub issue(s): #111

What does this Pull Request do?

  • Removes unnecessary repositories in pom.xml;
  • Removes openwayback-core which should have been removed in the warcbase to aut move (sorry, I missed that one!);
  • and cleans up formatting.

How should this be tested?

I've tested it locally by rm -f ~/.m2/repository/* && mvn clean install, and it build fine. It also passes on TravisCI so this should partially address the issue, and be fully resolved by cutting another release. @dportabella let me know if this looks good to you, and we'll proceed. Thanks for letting us know about the issue btw 😃

Interested parties

@dportabella, @lintool

@codecov
Copy link

codecov bot commented Nov 11, 2017

Codecov Report

Merging #112 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #112   +/-   ##
======================================
  Coverage    65.6%   65.6%           
======================================
  Files          36      36           
  Lines         721     721           
  Branches      140     140           
======================================
  Hits          473     473           
  Misses        199     199           
  Partials       49      49

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 069c862...81c2708. Read the comment docs.

@ruebot ruebot requested a review from lintool November 11, 2017 15:41
Copy link
Member

@lintool lintool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants