Skip to content

Commit

Permalink
Remove .keepValidPages() on .all() Python implementation. (#503)
Browse files Browse the repository at this point in the history
- Resolves #502
- Update test
- Run GitHub actions on correct branch
  • Loading branch information
ruebot committed Jan 18, 2021
1 parent ccc4aaf commit 363a8e1
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/java-formatter.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: Java Formatter (Google Java Format)

on:
pull_request:
branches: [master]
branches: [main]

jobs:
formatting:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/python-formatter.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: Python Formatter (isort & black)

on:
pull_request:
branches: [master]
branches: [main]

jobs:
formatting:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/scala-formatter.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: Run Scala Formatter (scalafmt)

on:
pull_request:
branches: [master]
branches: [main]

jobs:
scalafmt-lint:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ class DataFrameLoader(sc: SparkContext) {
def all(path: String): DataFrame = {
RecordLoader
.loadArchives(path, sc)
.keepValidPages()
.all()
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -123,8 +123,10 @@ class DataFrameLoaderTest extends FunSuite with BeforeAndAfter {
assert(r_10.getAs[String](md5) == "e483512b65ba44d71e843c57de2adeb7")

val r_11 = all.select(url, mime_type).take(1)(0)
assert(r_11.getAs[String](url) == "http://www.archive.org/")
assert(r_11.getAs[String](mime_type) == "text/html")
assert(
r_11.getAs[String](url) == "filedesc://IAH-20080430204825-00000-blackbook.arc"
)
assert(r_11.getAs[String](mime_type) == "text/plain")
}

after {
Expand Down

0 comments on commit 363a8e1

Please sign in to comment.