support directory symlinks #68
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
I've been trying to create a zip file through
archiverbut was struggling to get thezip.symlink(linkPath, sourcePath)to work for directory symlinks. It turns out thatzip-streamneeds to work slightly differently in this situation: the mode needs to include 755. I've switched this behaviour in if the data being supplied indicates that it's a directory symlink via the presence of a/suffix on thenameand thelinkname. An alternative approach would be to add another boolean (isDirectorySymlinkor similar), but I didn't want to increase the api surface area.I've added a test which generates a zip with a directory symlink in it - it seems to work ok for me when I unzip it.