potential fix for jsonld import bug, re #7542 #7546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apeters
changed the title
azaroth42
reviewed
Jul 2, 2021
| @@ -429,8 +431,21 @@ def is_concept_node(self, uri): | |||
| return True | |||
| return False | |||
|
|
|||
| def find_local_references(self, jsonld_document): | |||
| if "@id" in jsonld_document and "@type" in jsonld_document: | |||
There was a problem hiding this comment.
suggest a further check that it is NOT a tile reference, as tiles can only exist in one place in the tree.
There was a problem hiding this comment.
what would that check look like? I'm unsure of how to check for that.
There was a problem hiding this comment.
I assume you mean references like these
"http://localhost:8000/tile/d83757c8-203e-4755-b1fb-45e260105d78/node/e2f83f46-bacf-11ea-81b2-3af9d3b32b71"
There was a problem hiding this comment.
To me, the added complexity of implementing a regex to filter out those tile references doesn't seem to offset the additional entries in the cache. I think I'm just going to leave it as it for now.
chiatt
approved these changes
Jul 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re #7542