Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry pick pr 4945 to master #4996

Merged
merged 2 commits into from
Jul 11, 2019
Merged

Cherry pick pr 4945 to master #4996

merged 2 commits into from
Jul 11, 2019

Conversation

mradamcox
Copy link
Member

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description of Change

Please see #4945 for a description of the change.

Checklist

  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@coveralls
Copy link

Coverage Status

Coverage remained the same at ?% when pulling 5560fd2 on legiongis:cherry_pick_PR_4945_to_master into d5df55f on archesproject:master.

@mradamcox mradamcox merged commit d0e0b71 into archesproject:master Jul 11, 2019
@mradamcox mradamcox deleted the cherry_pick_PR_4945_to_master branch August 12, 2019 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mradamcox @coveralls