-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updates workflows for step components #4720
Conversation
arches/app/views/api.py
Outdated
@@ -496,3 +496,136 @@ def get(self, request, conceptid=None): | |||
return JSONResponse(status=500, reason=e) | |||
|
|||
return JSONResponse(ret, indent=indent) | |||
|
|||
from django.utils.translation import ugettext as _ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E402 module level import not at top of file
|
||
from django.utils.translation import ugettext as _ | ||
|
||
def get_resource_relationship_types(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E302 expected 2 blank lines, found 1
arches/app/views/api.py
Outdated
c[1])} for c in resource_relationship_types], 'default': str(default_relationshiptype_valueid)} | ||
return relationship_type_values | ||
|
||
class Card(APIBase): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E302 expected 2 blank lines, found 1
class Card(APIBase): | ||
|
||
|
||
def get(self, request, nodegroupid): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E303 too many blank lines (2)
# if the tile has authoritaive data and the current user is not the owner, | ||
# we don't send the provisional data of other users back to the client. | ||
tile.provisionaledits = None | ||
if append_tile == True: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E712 comparison to True should be 'if cond is True:' or 'if cond:'
card['is_writable'] = True | ||
|
||
|
||
context = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E303 too many blank lines (2)
arches/app/views/api.py
Outdated
|
||
|
||
context = { | ||
#main_script: main_script, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E265 block comment should start with '# '
arches/app/views/api.py
Outdated
'is_system_settings': is_system_settings | ||
} | ||
|
||
return JSONResponse(context, indent=4) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
W292 no newline at end of file
], function(ko) { | ||
return ko.components.register('new-tile-step', { | ||
viewModel: function(params) { | ||
console.log(params); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unexpected console statement. (no-console)
@@ -299,7 +300,7 @@ def get(self, request, resourceid=None, slug=None, graphid=None): | |||
# Here we actually mean the name | |||
#"label": str(model.name), | |||
"ldp:contains": ["%s%s" % (base_url, resourceid) for resourceid in list(Resource.objects.values_list('pk', flat=True). | |||
exclude(pk=settings.SYSTEM_SETTINGS_RESOURCE_ID).order_by('pk')[start:end])] | |||
exclude(pk=settings.SYSTEM_SETTINGS_RESOURCE_ID).order_by('pk')[start:end])] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E501 line too long (168 > 119 characters)
re: #4669