add the choice to only show selected node in dropdown #4658 #4663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
stickler-ci
reviewed
Mar 6, 2019
| if (nodeid !== displayValue.nodeid) { | ||
| markup += getDisplayValueMarkup(displayValue); | ||
| } | ||
| })}; |
There was a problem hiding this comment.
Expected indentation of 20 spaces but found 16. (indent)
Missing semicolon. (semi)
Unnecessary semicolon. (no-extra-semi)
Update master with archesproject master
…values of a tile in the dropdown option, or just the selected node. re #4658
stickler-ci
reviewed
Mar 7, 2019
| @@ -46,6 +46,10 @@ define([ | |||
| this.form.on('after-update', updateTiles); | |||
| } | |||
|
|
|||
| this.toggleDisplayOnlySelected = function(){ | |||
| this.displayOnlySelectedNode(!this.displayOnlySelectedNode()); | |||
| } | |||
There was a problem hiding this comment.
Missing semicolon. (semi)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
adds widget config to node value widget to control how options are displayed in select2 dropdown re #4658