Mark passwords as sensitive variables #11652 #11653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can test with the standard django error view but, since DEBUG=True doesn't bother masking, the least realistic but fatest way to configure this to test would be hack this line in your django install to return True: Then you should be able to throw errors inside any of these views and see the masking inside the django error view (but again, more realistically, we'd be talking about logs or emails to admins in prod environments, not the django error view): 
|
jacobtylerwalls
force-pushed
the
jtw/sensitive-variables
branch
from
f6e27bc to
233f188
Compare
chiatt
requested changes
Jan 18, 2025
jacobtylerwalls
force-pushed
the
jtw/sensitive-variables
branch
from
8ed08e1 to
cc89006
Compare
chiatt
requested changes
Jan 23, 2025
arches/app/views/auth.py
Outdated
Comment on lines
225
to
228
| @method_decorator( | ||
| sensitive_variables(), | ||
| sensitive_post_parameters(), | ||
| ) |
There was a problem hiding this comment.
This only seems to work when the methods are within an iterator (as I see you've done elsewhere)
chiatt
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description of Change
Limit occurrences of passwords in error reports (if configured) in production.
Issues Solved
Closes #11652