-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review and update dependencies #4842
Comments
For what it's worth I just commented
The version of urllib3 that was installed is On further investigation, this PR indicates that the version was pinned because of a CI failure: #4207 Here's the failed CI test from the PR history that directly precedes the pinning of Looks like it was Personally I think it would be preferable to remove |
@benosteen reports that Travis builds also work just fine with these two libraries removed from requirements.txt https://travis-ci.org/benosteen/arches/builds/535521352 |
The diff to master is linked through that travis report, but the key change
I made is just the removal of urllib and pyyaml from requirements.txt (
benosteen@e02a0c05d0ea#diff-556b1c9baefb39f9b9018530c098d2dc
)
I checked its logs and it did run the tests and they passed. (There is also
a change to the .travis.yml that adds an attempt to run the project with
python 3.6, which is optional and currently failing as expected)
Ben
…On Wed, 22 May 2019 at 09:56, mradamcox ***@***.***> wrote:
@benosteen <https://github.com/benosteen> reports that Travis builds also
work just fine with these two libraries removed from requirements.txt
https://travis-ci.org/benosteen/arches/builds/535521352
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4842?email_source=notifications&email_token=AABAX4AHYCZN3C4SEQGWJEDPWV3LBA5CNFSM4HOOFNP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODV7VTGY#issuecomment-494885275>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABAX4GHYBLWVOHYUJTAGZTPWV3LBANCNFSM4HOOFNPQ>
.
|
nice work on the python 3 test, that'll be useful in the upcoming year... |
Works as expected |
PyYaml is unused and urllib3 needs to be updated
The text was updated successfully, but these errors were encountered: