Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review and update dependencies #4842

Closed
apeters opened this issue May 21, 2019 · 5 comments
Closed

Review and update dependencies #4842

apeters opened this issue May 21, 2019 · 5 comments
Assignees
Labels
Subject: Security Type: Dependencies Upgrades Upgrades of major arches dependencies

Comments

@apeters
Copy link
Member

apeters commented May 21, 2019

PyYaml is unused and urllib3 needs to be updated

@apeters apeters added Subject: Security Type: Dependencies Upgrades Upgrades of major arches dependencies labels May 21, 2019
@mradamcox
Copy link
Member

mradamcox commented May 21, 2019

For what it's worth I just commented urllib3 out from requirements.txt and then ran

cd arches
pip install -e .
pip install -r arches/install/requirements.txt
pip install -r arches/install/requirements_dev.txt

The version of urllib3 that was installed is 1.25.2

On further investigation, this PR indicates that the version was pinned because of a CI failure: #4207

Here's the failed CI test from the PR history that directly precedes the pinning of urllib3 to 1.23

https://travis-ci.org/archesproject/arches/builds/442884629?utm_source=github_status&utm_medium=notification

Looks like it was requests that didn't support 1.24 at the time

Personally I think it would be preferable to remove urllib3 from requirements.txt. It's confusing if it's in there but not directly used in Arches.

@mradamcox
Copy link
Member

@benosteen reports that Travis builds also work just fine with these two libraries removed from requirements.txt https://travis-ci.org/benosteen/arches/builds/535521352

@benosteen
Copy link
Contributor

benosteen commented May 22, 2019 via email

@mradamcox
Copy link
Member

nice work on the python 3 test, that'll be useful in the upcoming year...

chiatt added a commit that referenced this issue May 30, 2019
@chiatt chiatt assigned njkim and chiatt and unassigned njkim May 30, 2019
@chiatt
Copy link
Member

chiatt commented Jul 1, 2019

Works as expected

@chiatt chiatt closed this as completed Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Subject: Security Type: Dependencies Upgrades Upgrades of major arches dependencies
Projects
None yet
Development

No branches or pull requests

5 participants