-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spack-solvable versions, add tests to Spack workflow #2156
Spack-solvable versions, add tests to Spack workflow #2156
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, some wording though (and I am scared of curl | bash
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Merge remote-tracking branch 'upstream/master' into spack_improvements
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Changes
build_spack_package.sh
. This script does everything in/tmp
, and Github Actions appear to be wiping/tmp
between steps, which means breaking up the run into steps is difficult. Breaking up is desirable, because then one can see whether building or testing breaks.ciwheelbuild
failure.Future issues
Out of scope for now, but identified as problems:
This mean that despite oru
package.py
properly includingdepends_on("googletest@1.12.1", type="test", when="@0.7.1:")
, Spack does not build it, at least not in the dev-build workflow as we currently do. And it isn't clear what an always working workaround is, see issue. (Spack can't display the deps for thetest
variant: spack spec/solve include option for --test dependencies spack/spack#23586spack spec -I arbor
doesn't show Google Test, and neither doesspack dependencies --deptype test arbor
.)