Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVE backend #2148

Merged
merged 16 commits into from
Aug 3, 2023
Merged

SVE backend #2148

merged 16 commits into from
Aug 3, 2023

Conversation

boeschf
Copy link
Contributor

@boeschf boeschf commented Jul 4, 2023

This PR attempts to fix the bugs reported in issue #2101 and introduces a new fixed-sized (VLS) sve backend. This backend does away with the need for variable sized arrays and runtime calls to figure out the simd width. Later we may want to retire the original sizeless (VLA) sve backend in favor of the new one.

Changes:

  • new sve backend with abi vls_sve: fixed-sized types, can be used wherever avx types and co can be used
  • configure time detection of sve register size
  • added pertinent compiler flags when sve is in use
  • modcc now generates correct code for all backends, and generates a constexpr simd_witdth_ (was previously not working with sve)
  • fixed small bug in sve exp function
  • updated tests

@boeschf boeschf requested review from thorstenhater and bcumming July 4, 2023 16:17
@brenthuisman
Copy link
Contributor

What is the significance of the cscs tests failing? Should they be passing?

@boeschf
Copy link
Contributor Author

boeschf commented Jul 31, 2023

No, ignore the cscs tests here - they fail because PR #2149 isn't merged yet, and I have the webhook enabled to run these tests for for me always (other users need to trigger them using a comment). Thus, it tries to run test scripts which aren't available yet.

@brenthuisman brenthuisman removed the request for review from bcumming August 2, 2023 11:27
Copy link
Contributor

@thorstenhater thorstenhater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell this looks sane and good catch on the misused intrinsic in exp

@boeschf boeschf merged commit 03e406f into arbor-sim:master Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants