Apply some polish to model construction. #2134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brenthuisman
suggested changes
Jun 7, 2023
|
Done and fixed the examples to the new nice syntax ;) |
brenthuisman
previously approved these changes
Jun 28, 2023
* C/V error in doc * Syntax error in example * Try to appease gcc-12 in CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make single cell model a bit more convenient by allowing to build from {morph | segment_tree, decor, {labels}.
Allow kwargs to construct mechanisms (density, scaled, junction, synapse, voltage), thus we can write
instead of