Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CV area exposed to NMODL. #2110

Merged
merged 4 commits into from
Jun 7, 2023
Merged

CV area exposed to NMODL. #2110

merged 4 commits into from
Jun 7, 2023

Conversation

thorstenhater
Copy link
Contributor

@thorstenhater thorstenhater commented Apr 19, 2023 •
edited
Loading

Add area variable in NMODL, this is used by concentration models where flux over the membrane is proportional
to ionic current, the (lateral) CV area, and Faraday's constant and diffusive models which have similar formulae.

Also pushes ion state and solver construction into shared state to isolate fvm_lowered from that duty.
Simplifies the construction of ion state.

Closes #2105

@brenthuisman brenthuisman self-requested a review April 25, 2023 11:28
jlubo
jlubo reviewed Apr 26, 2023
View reviewed changes
Copy link
Collaborator

@jlubo jlubo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the changes related to the area variable look good (I added one suggestion for the documentation). I don't understand what has changed regarding the ion state, however.

boeschf
boeschf reviewed May 8, 2023
View reviewed changes
Copy link
Contributor

@boeschf boeschf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. One minor opportunity to avoid some allocations.

boeschf
boeschf approved these changes Jun 6, 2023
View reviewed changes
Copy link
Contributor

@boeschf boeschf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@brenthuisman brenthuisman merged commit 235b291 into arbor-sim:master Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlubo jlubo jlubo left review comments

@boeschf boeschf boeschf approved these changes

@AdhocMan AdhocMan Awaiting requested review from AdhocMan

@brenthuisman brenthuisman Awaiting requested review from brenthuisman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Accessing CV area in mechanisms
4 participants
@thorstenhater @jlubo @boeschf @brenthuisman