Make LIF cells probeable. #2021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boeschf
reviewed
Nov 1, 2022
| @@ -16,11 +16,17 @@ struct ARB_SYMBOL_VISIBLE lif_cell { | |||
| double C_m = 20; // Membrane capacitance [pF]. | |||
| double E_L = 0; // Resting potential [mV]. | |||
| double V_m = E_L; // Initial value of the Membrane potential [mV]. | |||
| double V_reset = E_L; // Reset potential [mV]. | |||
There was a problem hiding this comment.
why was this member there in the first place?
There was a problem hiding this comment.
That's a very good question. It was never used, but set in all the examples and mentioned in the docs...
I am contemplating on whether we should be adding it back in, but this time it should be actually doing
something ;)
I'll ask some of your LIF-savvy users.
- Better naming - Safety invariantscc
boeschf
approved these changes
Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1263 (note that the ISI can be obtained otherwise and we can also add it later)