bump pybind11 for py3.11 compat #1955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brenthuisman
added
python
packaging
|
Never use a |
thorstenhater
approved these changes
Aug 26, 2022
There was a problem hiding this comment.
Apart from my irrational fear of .0 versions looks good. Here are some tidbits from the pybind11 changelog I am modestly excited about
- error_already_set is now safer and more performant, especially for exceptions with long tracebacks, by delaying computation. #1895
- The bindings for capsules now have more consistent exception handling. #3825
X-lang Exception handling has been a constant bane.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With a Python 3.11 RC out, our CI wheel builder was running into problems: https://github.com/arbor-sim/arbor/runs/7936097742?check_suite_focus=true#step:7:4491
This PR bumps the Pybind11 module to 2.10.0, which provides
WindowsPython 3.11 support. See https://github.com/arbor-sim/arbor/actions/runs/2902228009