Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Elaborate on mpi4py. #1940

Merged
merged 1 commit into from
Aug 9, 2022
Merged

Elaborate on mpi4py. #1940

merged 1 commit into from
Aug 9, 2022

Conversation

thorstenhater
Copy link
Contributor

@thorstenhater thorstenhater commented Aug 5, 2022 •
edited
Loading

Explain that

  • mpi4py might be needed when throwing MPI error.
  • mpi4py needs to be baked into Arbor at build time.

Closes #1785

@thorstenhater thorstenhater requested a review from Helveg August 5, 2022 08:23
Helveg
Helveg approved these changes Aug 5, 2022
View reviewed changes
Copy link
Collaborator

@Helveg Helveg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's good!

boeschf
boeschf approved these changes Aug 9, 2022
View reviewed changes
Copy link
Contributor

@boeschf boeschf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it gives a better error message, I think the issue can be resolved like this.

@thorstenhater thorstenhater merged commit 8bf65cd into arbor-sim:master Aug 9, 2022
@thorstenhater thorstenhater deleted the quality/mpi-error branch August 9, 2022 10:51
@thorstenhater
Copy link
Contributor Author

Explain that

mpi4py might be needed when throwing MPI error.
mpi4py needs to be baked into Arbor at build time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Helveg Helveg Helveg approved these changes

@boeschf boeschf boeschf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Passing COMM_WORLD to context constructors fails if mpi4py is installed after arbor is built
3 participants
@thorstenhater @Helveg @boeschf