Diffusion Example Improvements (and a bit of clean-up) #1914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ax.plot(xs, ys, label=lbl) | ||
| ax.plot(d[:, 0], d[:, ix], label=lbl) | ||
| # Table | ||
| print("Sodium concentration (NaD/mM)") |
There was a problem hiding this comment.
Can we use pandas/sth else to pretty print the table?
There was a problem hiding this comment.
In theory yes, but the code is usually neither more comprehensible nor shorter. You would be looking for
DataFrame::to_string(buf=None, columns=None, col_space=None, header=True, index=True, na_rep='NaN', formatters=None, float_format=None, sparsify=None, index_names=True, justify=None, max_rows=None, max_cols=None, show_dimensions=False, decimal='.', line_width=None, min_rows=None, max_colwidth=None, encoding=None) .
There was a problem hiding this comment.
something else = pip install tabulate, but I am not going to add a dependency for that
brenthuisman
approved these changes
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Post-Merge clean-up for the diffusion PR
WRITEs in mechanisms