Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses a problem occuring when a ionic (accumulated) quantity is
declared as
WRITE
, we have a block (any will do) that just reads it andmodcc
emits SIMD code.Example
In this case
modcc
conservatively assumes that it will be written as well and emitsbut 'forgets' to define
w_
. In scalar mode it's fine, since we just useweight[index]
without a temporary.
Solution
Be less fancy, just emit the SIMD code for
equally conservatively, read always.