Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modcc: generate missing node_index read needed for reading time t in the mechanisms #1866

Merged
merged 3 commits into from
May 5, 2022
Merged

modcc: generate missing node_index read needed for reading time t in the mechanisms #1866

merged 3 commits into from
May 5, 2022

Conversation

noraabiakar
Copy link
Contributor

Rectify the assumption that the node_index is read in every mechanism call back where time is also read.

@noraabiakar noraabiakar marked this pull request as draft March 24, 2022 16:19
@noraabiakar noraabiakar marked this pull request as ready for review March 29, 2022 09:22
thorstenhater
thorstenhater approved these changes May 5, 2022
View reviewed changes
Copy link
Contributor

@thorstenhater thorstenhater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@thorstenhater
Copy link
Contributor

Fix

@thorstenhater thorstenhater merged commit 75e9c1f into arbor-sim:master May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thorstenhater thorstenhater thorstenhater approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noraabiakar @thorstenhater